[17.0][MIG] website_odoo_debranding Migration to 17.0 #1017

NICO-SOLUTIONS · 2023-11-12T22:20:47Z

Standard migration to 17.0

pedrobaeza · 2023-11-12T22:24:55Z

/ocabot migration website_odoo_debranding

website_odoo_debranding/static/description/index.html

website_odoo_debranding/templates/disable_odoo.xml

astirpe

Tested in runboat and code review ok

AaronHForgeFlow

Functional

OCA-git-bot · 2024-01-11T09:59:48Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

astirpe

There's an error when installing this module and afterwards installing enterprise module planning:

Element '<xpath expr="//t[@t-call='web.brand_promotion_message']">' cannot be located in parent view

NICO-SOLUTIONS · 2024-01-25T19:57:01Z

There's an error when installing this module and afterwards installing enterprise module planning:

Element '<xpath expr="//t[@t-call='web.brand_promotion_message']">' cannot be located in parent view

good catch!
when installing planning, web.brand_promotion will be replaced by planning.brand_promotion. I´ll check xpathing another element...

NICO-SOLUTIONS · 2024-01-30T18:02:04Z

@astirpe
i think in this case switching back to inherit the web module is the better approach.
As we need to keep...
t t-call="web.brand_promotion_message"
in order to get it working with planning...

inheriting the web.brand_promotion_message and xpathing the fields seems to be the better choice.
As this would loose the character of a website module... What do you think?

astirpe · 2024-01-30T20:54:20Z

@NICO-SOLUTIONS

inheriting the web.brand_promotion_message and xpathing the fields seems to be the better choice. As this would loose the character of a website module... What do you think?

Yes, you are right: inheriting the web.brand_promotion_message would solve the conflicts.
I made a quick try locally with this xpath:

        <xpath expr="//t[@t-out]" position="replace">
            <t t-out=""/>
        </xpath>

but there are still some dirty characters left. So it seems not enough.

astirpe

Tested and works fine. Just don't know if the t-set needs to be replaced or not but it doesn't matter for the result.

website_odoo_debranding/templates/disable_odoo.xml

NICO-SOLUTIONS · 2024-01-31T09:58:54Z

Tested and works fine. Just don't know if the t-set needs to be replaced or not but it doesn't matter for the result.

I added this because I had some leftovers when this is not set. But I'll cross check later on

* Imported last updates from v8 * Adapted to v9 * Renamed to website_odoo_debranding * Updated README

- Relicensed to LGPL. - The template that does the job can be disabled by the admin.

…nment.manage()' Closes OCA#899

[UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-16.0/website-16.0-website_odoo_debranding Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_odoo_debranding/ [UPD] README.rst

With website_odoo_debranding installed it was not possible to install enterprise planning. Planning relies on <t t-call="web.brand_promotion_message"> sections which was removed with replacing the o_brand_promotion.

sanderlienaerts · 2024-03-25T08:14:16Z

Status for getting this one merged?

pedrobaeza · 2024-03-25T08:15:51Z

@sanderlienaerts you can collaborate reviewing the PR: https://odoo-community.org/page/review

But in this case, the existing reviewers are reputed ones,so merging:

/ocabot merge nobump

OCA-git-bot · 2024-03-25T08:15:58Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1017-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-03-25T08:19:49Z

Congratulations, your PR was merged at a698130. Thanks a lot for contributing to OCA. ❤️

NICO-SOLUTIONS · 2024-03-25T08:20:42Z

thanks! @pedrobaeza

NICO-SOLUTIONS marked this pull request as ready for review November 12, 2023 22:24

NICO-SOLUTIONS mentioned this pull request Nov 12, 2023

Migration to version 17.0 #1015

Open

13 tasks

OCA-git-bot added this to the 17.0 milestone Nov 12, 2023

tate11 reviewed Nov 24, 2023

View reviewed changes

website_odoo_debranding/static/description/index.html Show resolved Hide resolved

NICO-SOLUTIONS force-pushed the 17.0-mig-website_odoo_debranding branch from be384dc to 737e1ab Compare November 24, 2023 12:18

astirpe reviewed Jan 2, 2024

View reviewed changes

website_odoo_debranding/templates/disable_odoo.xml Outdated Show resolved Hide resolved

NICO-SOLUTIONS force-pushed the 17.0-mig-website_odoo_debranding branch from 737e1ab to 61179fb Compare January 2, 2024 18:46

astirpe reviewed Jan 3, 2024

View reviewed changes

website_odoo_debranding/templates/disable_odoo.xml Outdated Show resolved Hide resolved

NICO-SOLUTIONS force-pushed the 17.0-mig-website_odoo_debranding branch from 61179fb to 8ed802a Compare January 3, 2024 10:36

astirpe approved these changes Jan 3, 2024

View reviewed changes

AaronHForgeFlow approved these changes Jan 11, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 11, 2024

astirpe suggested changes Jan 25, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jan 25, 2024

NICO-SOLUTIONS force-pushed the 17.0-mig-website_odoo_debranding branch from 8ed802a to 1d24ea0 Compare January 30, 2024 21:54

NICO-SOLUTIONS requested a review from astirpe January 30, 2024 21:58

astirpe approved these changes Jan 31, 2024

View reviewed changes

website_odoo_debranding/templates/disable_odoo.xml Outdated Show resolved Hide resolved

OCA-git-bot added the approved label Jan 31, 2024

NICO-SOLUTIONS force-pushed the 17.0-mig-website_odoo_debranding branch from 1d24ea0 to 1161c0d Compare January 31, 2024 12:20

cubells and others added 3 commits March 23, 2024 15:00

[MIG] website_disable_odoo migration

5f153e4

* Imported last updates from v8 * Adapted to v9 * Renamed to website_odoo_debranding * Updated README

[FIX] website_odoo_debranding: runbot link

d1dba50

[MIG][website_odoo_debranding] Migrate to v10

42b7cdc

- Relicensed to LGPL. - The template that does the job can be disabled by the admin.

Tardo and others added 19 commits March 23, 2024 15:00

[IMP] website_odoo_debranding: black, isort, prettier

840005b

[MIG] website_odoo_debranding: Migration to 13.0

619510b

[UPD] Update website_odoo_debranding.pot

194e332

[UPD] README.rst

d076138

[UPD] README.rst

d244053

[MIG] Migrate module website_odoo_debranding to v14.

4ccd94b

[UPD] Update website_odoo_debranding.pot

87c8117

[UPD] README.rst

28b00d0

Added translation using Weblate (Spanish (Argentina))

620d384

[IMP] website_odoo_debranding: black, isort, prettier

30c119b

[UPD] Update website_odoo_debranding.pot

4442b2d

[UPD] README.rst

7c682e4

[IMP] website_odoo_debranding: Avoid deprecation warning with 'Enviro…

e9b89e5

…nment.manage()' Closes OCA#899

website_odoo_debranding 15.0.1.0.1

5492ced

[FIX] Update copier template + linter fix

e5bb9ba

[IMP] website_odoo_debranding: pre-commit auto fixes

682a062

[MIG] website_odoo_debranding: Migration to 17.0

e376070

[FIX] inherit problems with planning enterprise module

8292862

With website_odoo_debranding installed it was not possible to install enterprise planning. Planning relies on <t t-call="web.brand_promotion_message"> sections which was removed with replacing the o_brand_promotion.

NICO-SOLUTIONS force-pushed the 17.0-mig-website_odoo_debranding branch from 1161c0d to 8292862 Compare March 23, 2024 14:01

OCA-git-bot added the bot is merging ⏳ label Mar 25, 2024

OCA-git-bot merged commit 3ed248f into OCA:17.0 Mar 25, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 25, 2024

NICO-SOLUTIONS deleted the 17.0-mig-website_odoo_debranding branch March 25, 2024 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] website_odoo_debranding Migration to 17.0 #1017

[17.0][MIG] website_odoo_debranding Migration to 17.0 #1017

NICO-SOLUTIONS commented Nov 12, 2023

pedrobaeza commented Nov 12, 2023

astirpe left a comment

AaronHForgeFlow left a comment

OCA-git-bot commented Jan 11, 2024

astirpe left a comment

NICO-SOLUTIONS commented Jan 25, 2024

NICO-SOLUTIONS commented Jan 30, 2024 •

edited

Loading

astirpe commented Jan 30, 2024

astirpe left a comment

NICO-SOLUTIONS commented Jan 31, 2024

sanderlienaerts commented Mar 25, 2024

pedrobaeza commented Mar 25, 2024

OCA-git-bot commented Mar 25, 2024

OCA-git-bot commented Mar 25, 2024

NICO-SOLUTIONS commented Mar 25, 2024

[17.0][MIG] website_odoo_debranding Migration to 17.0 #1017

[17.0][MIG] website_odoo_debranding Migration to 17.0 #1017

Conversation

NICO-SOLUTIONS commented Nov 12, 2023

pedrobaeza commented Nov 12, 2023

astirpe left a comment

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 11, 2024

astirpe left a comment

Choose a reason for hiding this comment

NICO-SOLUTIONS commented Jan 25, 2024

NICO-SOLUTIONS commented Jan 30, 2024 • edited Loading

astirpe commented Jan 30, 2024

astirpe left a comment

Choose a reason for hiding this comment

NICO-SOLUTIONS commented Jan 31, 2024

sanderlienaerts commented Mar 25, 2024

pedrobaeza commented Mar 25, 2024

OCA-git-bot commented Mar 25, 2024

OCA-git-bot commented Mar 25, 2024

NICO-SOLUTIONS commented Mar 25, 2024

NICO-SOLUTIONS commented Jan 30, 2024 •

edited

Loading